Re: [patch] ide updates

From: Peter Osterlund (petero2@telia.com)
Date: Sun Apr 21 2002 - 12:41:34 EST

Next message: Jeff Garzik: "Re: BK, deltas, snapshots and fate of -pre..."
Previous message: Larry McVoy: "Re: Suggestion re: [PATCH] Remove Bitkeeper documentation from Linux tree"
In reply to: Morten Helgesen: "Re: [patch] ide updates"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Morten Helgesen <morten.helgesen@nextframe.net> writes:

> On Fri, Apr 19, 2002 at 12:39:24PM -0400, Mark Hahn wrote:
> > > guys with other WD drives, in particular :) You can use the
> > > attached perl script, sent to me by Jens, to check you drives.
> >
> > did the script give valid results? (I wrote it...)
>
> sure - seems to work like a charm :)

There appears to be an off by one bug in the test that decides whether
to mail the results. The results are mailed if there are != 1 drives
found, instead of the supposedly intended != 0 test.

Here is a patch to fix it:

--- test-tcq.pl.old Sun Apr 21 19:35:22 2002
+++ test-tcq.pl Sun Apr 21 19:34:57 2002
@@ -22,7 +22,7 @@
         }
}

-if ($addr && $#goodies) {
+if ($addr && scalar(@goodies)) {
         open(M, "| mail -s TCQ-report $addr");
         print M @goodies;
         close(M);

-- 
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Jeff Garzik: "Re: BK, deltas, snapshots and fate of -pre..."
Previous message: Larry McVoy: "Re: Suggestion re: [PATCH] Remove Bitkeeper documentation from Linux tree"
In reply to: Morten Helgesen: "Re: [patch] ide updates"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Apr 23 2002 - 22:00:29 EST