Re: Patch, forward release() return values to the close() call

• Next message: David Schwartz: "Re: The network performance of linux"
• Previous message: Jeff Garzik: "Re: Patch, forward release() return values to the close() call"
• In reply to: Axel Kittenberger: "Patch, forward release() return values to the close() call"
• Next in thread: Oliver Neukum: "Re: Patch, forward release() return values to the close() call"
• Reply: Oliver Neukum: "Re: Patch, forward release() return values to the close() call"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Whoops, my apologies. The patch looks ok to me.

I read your text closely and the patch not close enough. As I said, it
is indeed wrong for a device driver to fail f_op->release(), "fail"
being defined as leaving fd state lying around, assuming that the system
will fail the fput().

But your patch merely propagates a return value, not change behavior,
which seems sane to me.

    Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: David Schwartz: "Re: The network performance of linux"
• Previous message: Jeff Garzik: "Re: Patch, forward release() return values to the close() call"
• In reply to: Axel Kittenberger: "Patch, forward release() return values to the close() call"
• Next in thread: Oliver Neukum: "Re: Patch, forward release() return values to the close() call"
• Reply: Oliver Neukum: "Re: Patch, forward release() return values to the close() call"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 23 2002 - 22:00:24 EST