Re: 2.5.5-pre1 rmmod usb-uhci hangs

From: Greg KH (greg@kroah.com)
Date: Fri Feb 15 2002 - 10:56:36 EST


On Fri, Feb 15, 2002 at 03:54:40PM +0100, Pierre Rousselet wrote:
> with 2.5.5-pre1 usb-uhci module can't unload. rmmod hangs, leaving the
> system unstable. in one circumstance the box freezed with an oops
> involving swapper pid0 . this doesn't happen with 2.5.4

Try this (untested, I haven't rebooted yet) patch:

thanks,

greg k-h

diff -Nru a/drivers/usb/usb.c b/drivers/usb/usb.c
--- a/drivers/usb/usb.c Thu Feb 14 22:47:21 2002
+++ b/drivers/usb/usb.c Thu Feb 14 22:47:21 2002
@@ -1979,11 +1979,11 @@
                                 if (driver->owner)
                                         __MOD_DEC_USE_COUNT(driver->owner);
                                 /* if driver->disconnect didn't release the interface */
- if (interface->driver) {
- put_device (&interface->dev);
+ if (interface->driver)
                                         usb_driver_release_interface(driver, interface);
- }
                         }
+ /* remove our device node for this interface */
+ put_device(&interface->dev);
                 }
         }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:01:07 EST