Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c

From: Gerd Knorr (kraxel@strusel007.de)
Date: Thu Feb 14 2002 - 11:37:05 EST

Next message: Gerd Knorr: "[patch] matroxfb fix"
Previous message: Gerd Knorr: "[PATCH] es1370 fix"
In reply to: Steven Cole: "[PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Next in thread: Steven Cole: "Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Reply: Steven Cole: "Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> - pmi_base = (unsigned short*)bus_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);
> + pmi_base = (unsigned short*)phys_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);

Looks fine to me. While s/bus/phys/ isn't the approximate fix for many
drivers, at this place it is correct. The address is a segment:offset
pointer to a physical memory address somewhere in the VESA BIOS.

Gerd

-- 
Man muß die Software wacker hüten
weil in der Welt die Hacker wüten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Gerd Knorr: "[patch] matroxfb fix"
Previous message: Gerd Knorr: "[PATCH] es1370 fix"
In reply to: Steven Cole: "[PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Next in thread: Steven Cole: "Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Reply: Steven Cole: "Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:01:03 EST