Re: another IDE cleanup: kill duplicated code

From: Matthias Andree (matthias.andree@stud.uni-dortmund.de)
Date: Wed Feb 13 2002 - 06:25:38 EST

Next message: Vojtech Pavlik: "Re: another IDE cleanup: kill duplicated code"
Previous message: Luigi Genoni: "Re: [reiserfs-dev] 2.5.4-pre1: zero-filled files reiserfs"
In reply to: Martin Dalecki: "Re: another IDE cleanup: kill duplicated code"
Next in thread: Andreas Dilger: "Re: another IDE cleanup: kill duplicated code"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 13 Feb 2002, Martin Dalecki wrote:

> Silly code like that:
>
> ide_add_setting(drive, "bios_cyl",
> SETTING_RW,

Why do you call it "silly" to encapsulate all that stuff and create and
change attributes (bios_cyl) through an object (drive)? I fail to see
your point, looks rather like bash & flame. It's not silly because it's
a different approach or style.

-- Matthias Andree

"They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." Benjamin Franklin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Vojtech Pavlik: "Re: another IDE cleanup: kill duplicated code"
Previous message: Luigi Genoni: "Re: [reiserfs-dev] 2.5.4-pre1: zero-filled files reiserfs"
In reply to: Martin Dalecki: "Re: another IDE cleanup: kill duplicated code"
Next in thread: Andreas Dilger: "Re: another IDE cleanup: kill duplicated code"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:53 EST