Re: small IDE cleanup: void * should not be used unless neccessary

From: Rob Radez (rob@osinvestor.com)
Date: Tue Feb 12 2002 - 18:02:16 EST


On Mon, 11 Feb 2002, Pavel Machek wrote:

> Hi!
>
> This is really easy, please apply. (It will allow me to kill few casts
> in future).
> Pavel
>
> --- linux/include/linux/ide.h Mon Feb 11 21:15:04 2002
> +++ linux-dm/include/linux/ide.h Mon Feb 11 22:36:12 2002
> @@ -529,7 +531,7 @@
>
> typedef struct hwif_s {
> struct hwif_s *next; /* for linked-list in ide_hwgroup_t */
> - void *hwgroup; /* actually (ide_hwgroup_t *) */
> + struct hwgroup_s *hwgroup; /* actually (ide_hwgroup_t *) */
> ide_ioreg_t io_ports[IDE_NR_PORTS]; /* task file registers */
> hw_regs_t hw; /* Hardware info */
> ide_drive_t drives[MAX_DRIVES]; /* drive info */

If you're doing this, would it make sense to get rid of the useless casting
of the hwgroup member?

Regards,
Rob Radez

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:51 EST