Re: [PATCH] printk prefix cleanups.

From: Zwane Mwaikambo (zwane@linux.realnet.co.sz)
Date: Tue Feb 12 2002 - 02:26:28 EST


On Tue, 12 Feb 2002, Pete Zaitcev wrote:

> > Here is a simple patch which reduces resultant binary size by 1.2k for
> > this particular module (opl3sa2). [...]
>
> > #define OPL3SA2_MODULE_NAME "opl3sa2"
> > +#define OPL3SA2_PFX OPL3SA2_MODULE_NAME ": "
>
> > - printk(KERN_ERR "opl3sa2: MSS mixer not installed?\n");
> > + printk(KERN_ERR OPL3SA2_PFX "MSS mixer not installed?\n");
>
> I do not believe that it shortens binaries. Care to quote
> size(1) output and /proc/modules with and without the patch?

It does _not_ reduce the memory footprint, that i knew before doing the
patch, the only thing it does do is reduce the resultant binary's
filesize. Surely thats worth it just for the space saving? size(1) reports
the same sizes for both patched and unpatched.

Regards,
        Zwane Mwaikambo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:47 EST