[PATCH] mmap can return incorrect errno

• Next message: David Mosberger: "Re: thread_info implementation"
• Previous message: David S. Miller: "Re: thread_info implementation"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

mmap currently sets errno to EINVAL when it should be ENOMEM.
SUS/POSIX states that ENOMEM should be returned when:

"MAP_FIXED was specified, and the range [addr, addr + len) exceeds
that allowed for the address space of a process; or if MAP_FIXED was
not specified and there is insufficient room in the address space to
effect the mapping."

The following patch (against 2.4.17) fixes this behaviour:

--- mm/mmap.c~ Tue Nov 6 11:12:25 2001
+++ mm/mmap.c Mon Feb 11 15:49:58 2002
@@ -620,7 +620,7 @@
 {
         if (flags & MAP_FIXED) {
                 if (addr > TASK_SIZE - len)
- return -EINVAL;
+ return -ENOMEM;
                 if (addr & ~PAGE_MASK)
                         return -EINVAL;
                 return addr;

Chris

-- 
cyeoh@au.ibm.com
IBM OzLabs Linux Development Group
Canberra, Australia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: David Mosberger: "Re: thread_info implementation"
• Previous message: David S. Miller: "Re: thread_info implementation"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:46 EST