Re: [PATCH] Fix rocket port driver

From: Jeff Garzik (garzik@havoc.gtf.org)
Date: Wed Jan 30 2002 - 20:16:40 EST


On Thu, Jan 31, 2002 at 12:31:30AM +0100, Andi Kleen wrote:

Cool.

> @@ -2042,6 +2046,10 @@
> PCI_DEVICE_ID_RP8M, i, &bus, &device_fn))
> if(register_PCI(count+boards_found, bus, device_fn))
> count++;
> + if(!pcibios_find_device(PCI_VENDOR_ID_RP,
> + 0x8, i, &bus, &device_fn))
> + if(register_PCI(count+boards_found, bus, device_fn))
> + count++;

Would it be possible to beg and plead and convince you to convert this
driver to the new PCI API?

It hasn't been touched in ages AFAICS, and both 2.4 as well as 2.5 would
greatly benefit from such a [tested] change.

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:01:29 EST