Re: Configure.help in 2.5.3-pre6

From: Linus Torvalds (torvalds@transmeta.com)
Date: Wed Jan 30 2002 - 01:35:43 EST


In article <1012370595.3392.21.camel@phantasy>,
Robert Love <rml@tech9.net> wrote:
>
>The intention is to fix [menu|x]config. I believe plain 'ol `make
>config' works. The new per-config.in config.help is here to stay.

Yes. On the other hand, if there are real problems with converting
menu/x config to multiple help-files, a short-term answer might indeed
be just the silly "concatenate everything into the same file".

I'd much _prefer_ to have somebody who knows menuconfug/xconfig (or just
wants to learn). I have a totally untested patch for menuconfig, that
probably just works (like the regular config thing it doesn't actualy
take _advantage_ of pairing the Config.help files up with the questions,
but at least it should give you the help texts like it used to).

I don't know tcl/tk _at_all_, so I haven't even looked at what the
required syntax is for header.tk to use the same kind of "find . -name
Config.help" thing.

                Linus

----- UNTESTED patch, use at your own risk -----
diff -u --recursive pre6/linux/scripts/Menuconfig linux/scripts/Menuconfig
--- pre6/linux/scripts/Menuconfig Sun Aug 5 13:12:41 2001
+++ linux/scripts/Menuconfig Tue Jan 29 22:31:46 2002
@@ -357,19 +357,18 @@
 
 
 #
-# Extract available help for an option from Configure.help
+# Extract available help for an option from Config.help
 # and send it to standard output.
 #
 # Most of this function was borrowed from the original kernel
 # Configure script.
 #
 function extract_help () {
- if [ -f Documentation/Configure.help ]
- then
- #first escape regexp special characters in the argument:
- var=$(echo "$1"|sed 's/[][\/.^$*]/\\&/g')
- #now pick out the right help text:
- text=$(sed -n "/^$var[ ]*\$/,\${
+ #first escape regexp special characters in the argument:
+ var=$(echo "$1"|sed 's/[][\/.^$*]/\\&/g')
+ #now pick out the right help text:
+ text=$(cat /dev/null $(find . -name Config.help) |
+ sed -n "/^$var[ ]*\$/,\${
                         /^$var[ ]*\$/c\\
 ${var}:\\
 
@@ -378,19 +377,15 @@
                         s/^ //
                         /<file:\\([^>]*\\)>/s//\\1/g
                         p
- }" Documentation/Configure.help)
+ }")
 
- if [ -z "$text" ]
- then
- echo "There is no help available for this kernel option."
- return 1
- else
- echo "$text"
- fi
- else
- echo "There is no help available for this kernel option."
- return 1
- fi
+ if [ -z "$text" ]
+ then
+ echo "There is no help available for this kernel option."
+ return 1
+ else
+ echo "$text"
+ fi
 }
 
 #

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:01:13 EST