Re: [PATCH] scsi uodate to remove io_request_lock

From: Jens Axboe (axboe@suse.de)
Date: Mon Jan 28 2002 - 04:08:04 EST


On Mon, Jan 28 2002, Evgeniy Polyakov wrote:
> Hello, Jens Axboe, Linus Torvalds and other linux kernel hackers.
>
> Here is patch against 2.5.3-pre5 which removes io_request_lock.

You seem to be using &host->host_lock, which isn't quite right. SCSI
adapters pass down a preferred lock with scsi_assign_lock, and host_lock
_points_ to that lock. So you need to be using host->host_lock. A
compile should have caught this error (build SMP, of course).

> But unfortunnually here is 1 file (drivers/scsi/3w-xxxx.c),
> which still use spinning locks with io_request_lock because of detect()
> method, in which we cann't send Scsi_Host pointer. So this file must be
> corrected in some other way.

->detect() is not called with the lock held anymore...

> So, please check and apply.

You still have a bit of work to do :-)

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 31 2002 - 21:00:49 EST