[PATCH]Re: OOPS in APM 2.4.18-pre4 with i830MP agpgart

From: Nicolas Aspert (Nicolas.Aspert@epfl.ch)
Date: Sat Jan 19 2002 - 03:44:10 EST


Didier Moens wrote:

> Dear all,
>
> On november 27th, Nicolas Aspert was so kind as to post a modification
> to agpgart, which catters for detection of the Intel i830MP.
>
> The patch was included in 2.4.18-pre2.
>
> Unfortunately, loading agpgart yields an oops when APM ("apm -s") is
> invoked, both in terminal and in X. APM functions perfectly when agpgart
> is absent.
>
>
>

Hello all

Here is a patch that fixes the APM/suspend/resume issues in agpgart (for
820 and 830MP chipsets).
The patch is against 2.4.18-pre4

Have a nice week-end.

Nicolas

-- 
Nicolas Aspert      Signal Processing Laboratory (LTS)
Swiss Federal Institute of Technology (EPFL)

diff -Nru linux-2.4.18-pre4.clean/drivers/char/agp/agpgart_be.c linux-2.4.18-pre4.dirty/drivers/char/agp/agpgart_be.c --- linux-2.4.18-pre4.clean/drivers/char/agp/agpgart_be.c Sat Jan 19 09:35:00 2002 +++ linux-2.4.18-pre4.dirty/drivers/char/agp/agpgart_be.c Sat Jan 19 09:38:41 2002 @@ -1857,7 +1857,10 @@ agp_bridge.free_by_type = agp_generic_free_by_type; agp_bridge.agp_alloc_page = agp_generic_alloc_page; agp_bridge.agp_destroy_page = agp_generic_destroy_page; - + agp_bridge.suspend = agp_generic_suspend; + agp_bridge.resume = agp_generic_resume; + agp_bridge.cant_use_aperture = 0; + return 0; (void) pdev; /* unused */ @@ -1887,7 +1890,10 @@ agp_bridge.free_by_type = agp_generic_free_by_type; agp_bridge.agp_alloc_page = agp_generic_alloc_page; agp_bridge.agp_destroy_page = agp_generic_destroy_page; - + agp_bridge.suspend = agp_generic_suspend; + agp_bridge.resume = agp_generic_resume; + agp_bridge.cant_use_aperture = 0; + return 0; (void) pdev; /* unused */

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jan 23 2002 - 21:00:32 EST