On Fri, 11 Jan 2002, Pete Zaitcev wrote:
>
> I am terribly sorry, but an additional fixup is needed,
> as identified by Anders Rune Jensen (mental note - always
> cc submissions to linux-kernel. So many good eyeballs).
It would have been even saner to give that bit some sane name, and have
something like
#define YMFPCI_XXXBIT (__constant_cpu_to_le32(0x40000000))
instead of creating a totally nonsensical random number.
I applied your patch, but if I had created that code I would be too
ashamed to post such a patch on a public mailing list.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jan 15 2002 - 21:00:36 EST