Hugh Dickins wrote:
>
> There's two places, do_buffer_fdatasync
generic_buffer_fdatasync() and hence do_buffer_fdatasync()
are completely unused. It may be simpler to just trash
them.
> and __find_lock_page_helper,
Yeah. The code can't deadlock because:
page_cache_get();
spin_lock(&pagecache_lock);
page_cache_release();
we implicitly *know* that page_cache_release won't try
to acquire pagemap_lru_lock, because the page is in the
pagecache and has count=2 or more. Which is a bit, umm,
subtle.
I get the feeling that a lot of this would be cleaned up
if presence on an LRU contributed to page->count. It
seems strange, kludgy and probably racy that this is not
the case.
-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jan 15 2002 - 21:00:29 EST