Re: Patch?: linux-2.5.2-pre9/drivers/block/ll_rw_blk.c blk_rq_map_sg simplification

From: Dave Jones (
Date: Mon Jan 07 2002 - 08:02:24 EST

On Mon, 7 Jan 2002, Jens Axboe wrote:

> > The following patch removes gotos from blk_rq_map_sg, making
> > it more readable and five lines shorter. I think the compiler should
> > generate the same code. I have not tested this other than to
> > verify that it compiles.
> Well, I really think the original is much more readable than the changed
> version :-)

I agree. Upon seeing the patch, I was reminded of the monster
enormous conditional at
not quite _that_ bad, but getting there 8)

| Dave Jones.
| SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:34 EST