Re: [CFT] [JANITORIAL] Unbork fs.h

From: Ion Badulescu (
Date: Thu Jan 03 2002 - 11:05:07 EST

Hi Daniel,

On Thu, 3 Jan 2002 13:47:01 +0100, Daniel Phillips <> wrote:

> +static struct file_system_type ext2_fs = {
> + owner: THIS_MODULE,
> + fs_flags: FS_REQUIRES_DEV,
> + name: "ext2",
> + read_super: ext2_read_super,
> + super_size: sizeof(struct ext2_sb_info),
> + inode_size: sizeof(struct ext2_inode_info)
> +};

While we're at it, can we extend this model to also include details about
the other filesystem data structures with (potential) private info, i.e.
struct dentry and struct file? ext2 might not use them, but other
filesystems certainly do.

> -static inline struct inode * new_inode(struct super_block *sb)
> +static inline struct inode *new_inode (struct super_block *sb)

Minor issue of coding style. I'd steer away from such gratuitious changes,
especially since they divert from the commonly accepted practice of having
no spaces between the name of the function and its arguments.

[FiST co-maintainer]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:21 EST