Re: Serial Driver Name Question (kernels 2.4.x)

From: Andrew Morton (
Date: Thu Jan 03 2002 - 02:03:38 EST

Richard Gooch wrote:
> > Instead, it appears that someone broke tty_name(). Here's the
> > 2.2 kernel's version:
> That "someone" was me, and I changed it from broken to fixed.

Look at serial.c:

#if (LINUX_VERSION_CODE > 0x2032D && defined(CONFIG_DEVFS_FS)) = "tts/%d";
#else = "ttyS";

tty_name will just print "ttyS". So the transition for this case
was fixed->broken.

> No, originally tty_name() did it, and then I shifted it to the
> drivers. I don't recall the reason, but it was necessary. So I don't
> want this changed.

Oh dear. Why cannot devfs expand the minor part itself?

It looks like all the drivers need to be given a %d, as Ivan suggests. And we
need to audit all uses to make sure nobody is doing printk(;

I think it would be better to drop the printf control construct from the
names altogether.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:20 EST