Re: [PATCH] simple ide without proc compile fix

From: David Weinehall (tao@acc.umu.se)
Date: Wed Dec 05 2001 - 23:48:26 EST


On Wed, Dec 05, 2001 at 06:20:49PM -0500, Robert Love wrote:
> Attached patch is a repost now against 2.4.17-pre4.
>
> IDE will not compile without CONFIG_PROC_FS defined. This patch fixes
> that.
>
> Yes, ifdefs in the code are not preferred. But this is merely following
> the pattern in the rest of the ide*.c files (see other uses of
> ide_remove_proc_entries -- just these two seem to be without ifdefs).

Wouldn't a dummy, in case of no proc, be preferable? That'd make it
possible to remove all the #ifdef CONFIG_PROC_FS

/David
  _ _
 // David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Dec 07 2001 - 21:00:32 EST