Re: [PATCH] fix SCSI non-blocksize reads

From: Erik Andersen (andersen@codepoet.org)
Date: Thu Nov 22 2001 - 12:20:54 EST

Next message: Andrea Arcangeli: "Re: [PATCH] block_dev.c: fsync() on close() considered harmful"
Previous message: Russell King: "Re: anyone got the same problem with DIGITAL 21143 network card ?"
In reply to: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Next in thread: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Reply: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu Nov 22, 2001 at 09:09:23AM -0800, Linus Torvalds wrote:
>
> On Thu, 22 Nov 2001, Erik Andersen wrote:
> >
> > Several SCSI drivers blindly do reads of size 1024 when trying to read
> > the partition table. This fails on Magneto Optical drives and similar
> > odd devices with 2048 byte native sector sizes. This patch fixes that
> > so I can have partitions on my MO drive again (it lives on an Adaptec
> > card at present and has 2048 byte sectors),
>
> Please use the "block_size()" function instead of doing it by hand..

Ok. I just did it the same way most of the other SCSI drivers
do this...

Would you like a patch that also fixes all the other SCSI drivers
to use block_size() then, so they will be consistent?

-Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrea Arcangeli: "Re: [PATCH] block_dev.c: fsync() on close() considered harmful"
Previous message: Russell King: "Re: anyone got the same problem with DIGITAL 21143 network card ?"
In reply to: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Next in thread: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Reply: Linus Torvalds: "Re: [PATCH] fix SCSI non-blocksize reads"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 23 2001 - 21:00:30 EST