Re: [RFC] problem with grow_dev_page()/readpage()

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Nov 19 2001 - 15:20:42 EST


On Mon, 19 Nov 2001, Alexander Viro wrote:
>
> That breaks if you do bread() on something less than hardware sector size,
> though. Then all following attempts to read that page (until ->buffers
> is evicted) will keep trying to submit IO on too small buffers.

I don't think that can happen - you can only bread with i_blksize, and the
set_blocksize() stuff refuses to set to smaller than the hardware sector
size.

See

        /* Size cannot be smaller than the size supported by the device */
        if (size < get_hardsect_size(dev))
                return -EINVAL;

in set_blocksize().

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 23 2001 - 21:00:21 EST