Re: [PATCH] binfmt_misc.c, kernel-2.4.12

From: Richard Guenther (rguenth@tat.physik.uni-tuebingen.de)
Date: Fri Oct 19 2001 - 08:32:07 EST

Next message: Peter Moscatt: "Can't see IDE CDR-W after compile ?"
Previous message: safemode: "Re: problems with I/O performance with 2.4.12-ac3"
In reply to: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Next in thread: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Reply: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Linus,

As Al pissed me off again with complaining about binfmt_misc, please
apply the attached patch which corrects the 'not C code' line and
fixes the problem Albert noticed. This doesnt fix various assumptions
about the /proc code that were either valid at the time of writing
binfmt_misc or badly/not documented.

Feel free to use binfmt_misc version from -ac, I'm sure Al will take
responsibility of maintaining that crappy version then.

Thanx, Richard.

On Fri, 19 Oct 2001, Alexander Viro wrote:
> On Fri, 19 Oct 2001, Albert Bartoszko wrote:
> > Hello
> >
> > I find bug in binfmt_misc.c from kernel 2.4.12 source. The read() syscal
>
> only one?
>
> > return bad value, causes some application SIGSEGV.
>
> Hardly a surprise. Not everything that passes compiler is valid C.
> Stuff in fs/binfmt_misc.c from Linus' tree isn't. Pick one from -ac
> + corresponding change in fs/proc/root.c (again, see -ac). Variant
> in Linus' tree is complete crap.
>
> <goes back to sleep>

-- Richard Guenther <richard.guenther@uni-tuebingen.de> WWW: http://www.tat.physik.uni-tuebingen.de/~rguenth/ The GLAME Project: http://www.glame.de/

TEXT/PLAIN attachment: binfmt_misc-patch

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Peter Moscatt: "Can't see IDE CDR-W after compile ?"
Previous message: safemode: "Re: problems with I/O performance with 2.4.12-ac3"
In reply to: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Next in thread: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Reply: Alexander Viro: "Re: [PATCH] binfmt_misc.c, kernel-2.4.12"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Oct 23 2001 - 21:00:23 EST