Re: [PATCH] 2.4.11 min() in tcp.c

From: David S. Miller (
Date: Wed Oct 10 2001 - 18:56:59 EST

   From: Chris Wright <>
   Date: Wed, 10 Oct 2001 16:44:30 -0700

   tcp.c:855: warning: comparison of distinct pointer types lacks a cast
   the following patch, changes min() to min_t() to make size_t explicit.

Applied, but with a cleanup, please never do this:
   - min(
   + min_t (

"min_t" is not a C operator, therefore no reason to put a space
between "min_t" and the openning parenthesis. If you look around,
this is the general coding style rule the Linux code follows:

        if () /* <--- space here */
        while () /* <--- and here */
        foo_function() /* <--- but not here */

For example.

Franks a lot,
David S. Miller
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:35 EST