[PATCH]Fix bug:rmdir could remove current working directory

From: Mingming cao (cmm@us.ibm.com)
Date: Wed Oct 10 2001 - 19:32:45 EST

Hi Linus, Alan and Al,

I found that rmdir(2) could remove current working directory
successfully. This happens when the given pathname points to current
working directory, not ".", but something else. For example, the current
working directory's absolute pathname. I read the man page of
rmdir(2). It says in this case EBUSY error should be returned. I
suspected this is a bug and added a check in vfs_rmdir(). The following
patch is against 2.4.10 and has been verified. Please comment and

Mingming Cao

--- linux-2.4.10/fs/namei.c Tue Sep 18 11:01:47 2001 +++ /home/ming/linux-tk/fs/namei.c Tue Oct 9 11:58:50 2001 @@ -1362,6 +1362,8 @@ error = -ENOENT; else if (d_mountpoint(dentry)) error = -EBUSY; + else if (dentry == current->fs->pwd) + error = -EBUSY; else { lock_kernel(); error = dir->i_op->rmdir(dir, dentry); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:35 EST