PATCH: linux-2.4.10-pre14/drviers/net/irda/toshoboe.c module segfaults at removal if hardware absent

From: Adam J. Richter (adam@yggdrasil.com)
Date: Sun Sep 23 2001 - 01:29:16 EST

Next message: Rusty Russell: "[PATCH] PART1: Proposed init & module changes for 2.5"
Previous message: Adam J. Richter: "PATCH: linux-2.4.10-pre14/drivers/net/tlan.c ignored pci_module_init result"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

linux-2.4.10-pre14/drivers/net/irda/toshoboe.c
ignored the return value from pci_module_init() at module
load time, and then unconditionally calls pci_unregister_module
when the module is unloaded (even if the driver is not registered,
due to pci_module_init failing). I have verified that this results
in a kernel null pointer dereference if you load and unload this
module on a system lacking the toshboe hardware.

The following trivial patch fixes the problem by aborting
the module initialization if pci_module_init fails.

Please apply.

-- Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104 adam@yggdrasil.com \ / San Jose, California 95129-1034 +1 408 261-6630 | g g d r a s i l United States of America fax +1 408 261-6631 "Free Software For The Rest Of Us."

text/plain attachment: tosh.diff

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Rusty Russell: "[PATCH] PART1: Proposed init & module changes for 2.5"
Previous message: Adam J. Richter: "PATCH: linux-2.4.10-pre14/drivers/net/tlan.c ignored pci_module_init result"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:52 EST