Re: [PATCH] for drivers/char/sysrq.c

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Thu Sep 20 2001 - 07:38:16 EST


> How did something this basic get submitted in the first place?!?
> Doesn't anyone bother compiling patches before sending to Linus?
> This is the second time today I've had to patch the kernel just to get
> the rotten thing to compile. I'm not happy that whoever put in those
> __builtin_expect()'s didn't bother testing with THE RECOMMENDED
> COMPILER!!! It's not the first time that sort of thing has happened.
> </whinge>

It got broken because the stable kernel API isnt. When I submitted it to
Linus I missed one specific random api of the week variance. Its been in
the -ac tree and vendor distros for a while, so it was tested.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:37 EST