Re: PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices

From: Greg KH (greg@kroah.com)
Date: Wed Sep 05 2001 - 17:46:46 EST

Next message: Dax Kelson: "Re: [OFFTOPIC] Secure network fileserving Linux <-> Linux"
Previous message: Samium Gromoff: "more fruits, though not probably fresh"
In reply to: Adam J. Richter: "PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Sep 04, 2001 at 09:55:53PM -0700, Adam J. Richter wrote:

> --- linux-2.4.10-pre4/drivers/net/irda/irda-usb.c Sun Aug 5 13:12:40 2001
> +++ linux/drivers/net/irda/irda-usb.c Tue Sep 4 21:19:43 2001
> @@ -76,7 +76,8 @@
> { USB_DEVICE(0x50f, 0x180), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
> /* Extended Systems, Inc., XTNDAccess IrDA USB (ESI-9685) */
> { USB_DEVICE(0x8e9, 0x100), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
> - { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS,
> + { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS |
> + USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> bInterfaceClass: USB_CLASS_APP_SPEC,
> bInterfaceSubClass: USB_CLASS_IRDA,
> driver_info: IUC_DEFAULT, },

That should be:
{ USB_INTERFACE_INFO (USB_CLASS_APP_SPEC, USB_CLASS_IRDA, 0), driver_info: IUC_DEFAULT},

according to the IrDA USB spec.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Dax Kelson: "Re: [OFFTOPIC] Secure network fileserving Linux <-> Linux"
Previous message: Samium Gromoff: "more fruits, though not probably fresh"
In reply to: Adam J. Richter: "PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Sep 07 2001 - 21:00:33 EST