> What was you test scenario where you didn't see a completion callback?
The root hub emulation never posts one.
> > + if (ret == 0) { /* N.B. Done, must notify */
> > + /* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */
> > + urb->dev = NULL;
> > + if (urb->complete)
> > + urb->complete(urb);
> > + }
> >
> > - usb_dec_dev_use(urb->dev);
> > + usb_dec_dev_use(dev);
> What's all of this for? Protecting against an urb->dev race condition?
No race, but we cannot use urb after callback.
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Aug 31 2001 - 21:00:15 EST