On Tue, Aug 14, 2001 at 09:58:55AM -0700, Linus Torvalds wrote:
> - do we actually need the config switch AT ALL, whether at bootup or not?
> What exactly breaks if we just always pass the AA 00 values through?
> Apparently nothing ever breaks, which makes me suspect that people are
> just being unnecessarily defensive.
>
> In short, I'd prefer a patch that just unconditionally removes the code,
> unless somebody KNOWS that it could break something. That failing, a
> simple kernel command line option sounds better than more files in /proc.
OK, here come two patches. The first one removes the special PSAUX reconnect
handling completely. So userspace should handle it. (Which is possible; just
not implemented in gpm/X11 at this time AFAIK.)
Second patch reintroduces the special handling again, but does
* react on AA 00 instead of just AA, thus much less likely breaking other
drivers (such as synps2). All PS/2 mouses I could access (about 5
different models) produced AA 00, so this seems OK.
* is disabled by default, and needs to be enabled by the psaux-reconnect
boot parameter, like in 2.2.19.
Second patch depends on first. Please apply just the first or both.
(Current failure of gpm/X11 would make me choose for both, but then I'm
more the one thinking of customers of a distro than the one trying to keep
the kernel clean. On the long term, I'd drop the second in any case.)
Regards,
-- Kurt Garloff <garloff@suse.de> Eindhoven, NL GPG key: See mail header, key servers Linux kernel development SuSE GmbH, Nuernberg, DE SCSI, Security
This archive was generated by hypermail 2b29 : Wed Aug 15 2001 - 21:00:54 EST