Re: ReiserFS / 2.4.6 / Data Corruption

From: Chris Wedgwood (
Date: Tue Jul 31 2001 - 10:15:54 EST

On Tue, Jul 31, 2001 at 09:41:25AM -0400, Chris Mason wrote:

    if (some_error) {
        panic("some_error") ;

What a terrible construct... if would be much more elegant as:

        if(some_error) {

where _namesys_internal_foo is compiled differently and may not return
depending on CONFIG_REISERFS_CHECK and maybe also the error type.

That way we don't end up with even more #ifdef BLAH / #endif cruft
which obfuscates what is already hard to read code in places!

Flames welcome :)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Jul 31 2001 - 21:00:51 EST