Re: ReiserFS / 2.4.6 / Data Corruption

From: Chris Mason (
Date: Mon Jul 30 2001 - 10:24:16 EST

On Saturday, July 28, 2001 03:28:05 AM +1000 Andrew Morton
<> wrote:

[ patch to trigger data writes before commit in reiserfs ]

> There's no disruption to disk format - it just simulates
> the user typing `sync' at the right time. I think the
> concept is sound, and I'm sure Chris can find a more efficient
> way...

Well, its gets points for simplicity ;-)

What I think we need is for commit_write to put new buffers a per super
list of new buffers, and then the journal code can flush that list on

Since all the filesystems already mark things BH_New, it seems a good
choice to let commit_write look for BH_New buffers and put them on this new
list. But, the only place BH_New seems to get cleared right now is
unmap_buffer, which only gets called from block_flushpage.

Is there any reason we can't just clear BH_New before writing the buffer
out? It looks like a bug to leave it set the way we do now.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Jul 31 2001 - 21:00:44 EST