Re: [PATCH] Re: 2.4.8-pre1 build error in drivers/parport/parport_pc.c

From: Philip Blundell (
Date: Sat Jul 28 2001 - 16:06:43 EST

>The "extern" was only an escape for the case that the compiler cannot
>inline the function. Due to the fact, that current gcc has "static
>inline" it is better to use this, because with "static inline" we do
>not need to keep a global symbol just for the case the compiler is not
>capable to inline the function in some place.

The versions in the .c file are there so that the "ops" structure can point to
them. The ones in the .h file are purely an optimisation to allow you to
short-circuit the ops struct if you know only one driver is involved.

Changing this stuff to "static inline" still offends my sense of aesthetics
somewhat, but I guess it's okay if you have checked that it still does the
right thing in the CONFIG_PARPORT_OTHER case.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Jul 31 2001 - 21:00:39 EST