Re: [PATCH] Re: MTD compiling error

From: Eric W. Biederman (ebiederm@xmission.com)
Date: Fri Jul 20 2001 - 13:37:22 EST


David Woodhouse <dwmw2@infradead.org> writes:

> kiwiunix@ihug.co.nz said:
> > /usr/src/linux-2.4.6/include/linux/mtd/cfi.h:387: `do_softirq' undeclared
> (first use in this function)

Dave this isn't a sufficient fix. In particular amd_flash.c has problems,
if you only patch cfi.h. The problem is local_bh_enable by way of
do_unlock_bh. Or in particular the changes to asm-i386/softirq.h

The following should fix every case the changes to softirq.h broke. I would
love to include linux/interrupt.h but that isn't currently possible.

Eric

--- linux-2.4.6/include/asm-i386/softirq.h Thu Jul 19 15:33:26 2001
+++ linux-2.4.6.eb1.1/include/asm-i386/softirq.h Thu Jul 19 17:19:04 2001
@@ -4,6 +4,12 @@
 #include <asm/atomic.h>
 #include <asm/hardirq.h>
 
+/* FIXME getting the declaraion for do_softirq from interrupt.h is an
+ * include nightmare, this needs to be fixed instead of declaring
+ * do_softirq directly.
+ */
+extern asmlinkage void do_softirq(void);
+
 #define __cpu_bh_enable(cpu) \
                 do { barrier(); local_bh_count(cpu)--; } while (0)
 #define cpu_bh_disable(cpu) \

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 23 2001 - 21:00:13 EST