Re: [PATCH] sym53c8xx timer rework

From: Tim Hockin (thockin@sun.com)
Date: Tue Jul 10 2001 - 13:21:57 EST

Next message: Stephen C. Tweedie: "Re: [Ext2-devel] Re: 2.4.6 and ext3-2.4-0.9.1-246"
Previous message: Jesse Pollard: "Re: What is the truth about Linux 2.4's RAM limitations?"
In reply to: Studierende der Universitaet des Saarlandes : "Re: [PATCH] sym53c8xx timer rework"
Next in thread: Gérard Roudier: "Re: [PATCH] sym53c8xx timer rework"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Studierende der Universitaet des Saarlandes wrote:

> > + NCR_LOCK_NCB(np, flags);
> > + del_timer(&np->timer);
> > + NCR_UNLOCK_NCB(np, flags);
>
> I'm only reading the diff, but this change looks wrong.
> The simplest solution is del_timer_sync() instead of
> LOCK;del_timer;UNLOCK.

I didn't even realize there was a del_timer_sync(). That does what is
needed. 3 lines become 1, I guess.

Thanks, CC:ed to Gerard and crew.

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Stephen C. Tweedie: "Re: [Ext2-devel] Re: 2.4.6 and ext3-2.4-0.9.1-246"
Previous message: Jesse Pollard: "Re: What is the truth about Linux 2.4's RAM limitations?"
In reply to: Studierende der Universitaet des Saarlandes : "Re: [PATCH] sym53c8xx timer rework"
Next in thread: Gérard Roudier: "Re: [PATCH] sym53c8xx timer rework"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jul 15 2001 - 21:00:12 EST