Re: [PATCH] starfire net driver update

From: Ion Badulescu (ionut@cs.columbia.edu)
Date: Tue Jul 10 2001 - 12:24:00 EST


On Tue, 10 Jul 2001, Jeff Garzik wrote:

> Ion Badulescu wrote:
> > + unregister_netdev(dev); /* Will also free np!! */
> > + iounmap((char *)dev->base_addr);
> > + pci_release_regions(pdev);
> >
> > pci_set_drvdata(pdev, NULL);
> > + kfree(dev);
>
> no problem with the patch, this comment is wrong though. kfree frees
> np.

True, the comment should be moved 5 lines down. I'll fix it in the next
version.

Thanks,
Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 15 2001 - 21:00:12 EST