RE: [PATCH-2.4.3] scsi logging

From: Cress, Andrew R (andrew.r.cress@intel.com)
Date: Tue Jul 10 2001 - 07:40:23 EST


DG> I would object to point 3). SANE, and to a lesser extent
DG> cdrecord, execute lots of commands that give SCSI check
DG> conditions and would bloat the log and the console with
DG> many serious looking messages. [...]

Doug,

Would it be possible to recognize & filter the specific errors output by
SANE and cdrecord rather than removing all sg sense errors? Or to ignore
all but certain sense codes unless SG_SET_DEBUG is set?
What I'm most concerned about is to make sure that any media problems on
fixed disks (03/11/00, etc.) don't get missed.

Perhaps something like:
if (CHECK_CONDITION ...) {
  if ((type == disk && (key == MEDIUM_ERROR || key == HARDWARE_ERROR))
     || (sdp->sgdebug > 0))
        print_req_sense(...)
  }
How about that?

Andy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 15 2001 - 21:00:11 EST