Re: [patch] truncate_inode_pages

From: Andrew Morton (andrewm@uow.edu.au)
Date: Sat Jun 09 2001 - 20:31:38 EST


Daniel Phillips wrote:
>
> This is easy, just set the list head to the page about to be truncated.

Works for me.

--- linux-2.4.5/mm/filemap.c Mon May 28 13:31:49 2001
+++ linux-akpm/mm/filemap.c Sun Jun 10 11:29:19 2001
@@ -235,12 +235,13 @@
 
                 /* Is one of the pages to truncate? */
                 if ((offset >= start) || (*partial && (offset + 1) == start)) {
+ list_del(head);
+ list_add_tail(head, curr);
                         if (TryLockPage(page)) {
                                 page_cache_get(page);
                                 spin_unlock(&pagecache_lock);
                                 wait_on_page(page);
- page_cache_release(page);
- return 1;
+ goto out_restart;
                         }
                         page_cache_get(page);
                         spin_unlock(&pagecache_lock);
@@ -252,11 +253,14 @@
                                 truncate_complete_page(page);
 
                         UnlockPage(page);
- page_cache_release(page);
- return 1;
+ goto out_restart;
                 }
         }
         return 0;
+out_restart:
+ page_cache_release(page);
+ spin_lock(&pagecache_lock);
+ return 1;
 }
 
 
@@ -273,15 +277,18 @@
 {
         unsigned long start = (lstart + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
         unsigned partial = lstart & (PAGE_CACHE_SIZE - 1);
+ int complete;
 
-repeat:
         spin_lock(&pagecache_lock);
- if (truncate_list_pages(&mapping->clean_pages, start, &partial))
- goto repeat;
- if (truncate_list_pages(&mapping->dirty_pages, start, &partial))
- goto repeat;
- if (truncate_list_pages(&mapping->locked_pages, start, &partial))
- goto repeat;
+ do {
+ complete = 1;
+ while (truncate_list_pages(&mapping->clean_pages, start, &partial))
+ complete = 0;
+ while (truncate_list_pages(&mapping->dirty_pages, start, &partial))
+ complete = 0;
+ while (truncate_list_pages(&mapping->locked_pages, start, &partial))
+ complete = 0;
+ } while (!complete);
         spin_unlock(&pagecache_lock);
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jun 15 2001 - 21:00:11 EST