Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

From: Rasmus Andersen (rasmus@jaquet.dk)
Date: Fri May 25 2001 - 16:17:37 EST

Next message: Wayne.Brown@altec.com: "Re: The difference between Linus's kernel and Alan Cox's kernel"
Previous message: Linus Torvalds: "Re: [with-PATCH-really] highmem deadlock removal, balancing & cleanup"
In reply to: Jens Axboe: "Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote:
[...]
> This isn't right. Granted the locking isn't straight forward here, but
> take a look at ide_write_setting -> ide_spin_wait_hwgroup and the
> latters return value.

Yes, Andre set me straight here. My apologies for being lazy and
not checking the call path.

-- Rasmus(rasmus@jaquet.dk)

You know how dumb the average guy is? Well, by definition, half of them are even dumber than that. -- J.R. "Bob" Dobbs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Wayne.Brown@altec.com: "Re: The difference between Linus's kernel and Alan Cox's kernel"
Previous message: Linus Torvalds: "Re: [with-PATCH-really] highmem deadlock removal, balancing & cleanup"
In reply to: Jens Axboe: "Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:25 EST