Re: [PATCH] drivers/net/others

From: Rasmus Andersen (rasmus@jaquet.dk)
Date: Thu May 24 2001 - 13:22:15 EST


On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >- printk(version);
> >+#ifdef MODULE
> >+ printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing it just a little too safe, wouldn't you say?

With the above snippet of code being remailed a couple of times
somebody surely noticed before me that the printk should have
"%s" as format string, not "s". But then again somebody might
not so there you are.

-- 
        Rasmus(rasmus@jaquet.dk)

"A statesman... is a dead politician. Lord knows, we need more statesmen." -- Bloom County - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:18 EST