Re: IPv6 implementation in kernel 2.4.4 oopses

From: Andi Kleen (ak@suse.de)
Date: Wed May 23 2001 - 15:21:37 EST


On Wed, May 23, 2001 at 03:56:35PM -0400, David Gordon (LMC) wrote:
> >>EIP; c0237bc4 <ipv6_addr_type+4/e0> <=====
>
> What exactly was the problem that was fixed in the latest pre kernel ?

A coding mistake was fixed.

Here is the patch if you're interested (cut'n'pasted so not applicable)

RCS file: /cvs/linux/net/ipv6/ndisc.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -u -r1.49 -r1.50
--- net/ipv6/ndisc.c 2001/05/03 07:02:47 1.49
+++ net/ipv6/ndisc.c 2001/05/05 01:59:27 1.50
@@ -382,7 +382,7 @@
        int send_llinfo;
 
        len = sizeof(struct icmp6hdr) + sizeof(struct in6_addr);
- send_llinfo = dev->addr_len && ipv6_addr_type(saddr) != IPV6_ADDR_ANY;
+ send_llinfo = dev->addr_len && saddr && ipv6_addr_type(saddr) != IPV6_AD
DR_ANY;
        if (send_llinfo)
                len += NDISC_OPT_SPACE(dev->addr_len);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 23 2001 - 21:00:53 EST