Re: [PATCH] winbond-840 update

From: Manfred Spraul (manfred@colorfullife.com)
Date: Sat May 12 2001 - 09:43:57 EST


Jeff Garzik wrote:
>
> Manfred Spraul wrote:
> > @@ -437,9 +439,9 @@
> > if (option > 0) {
> > if (option & 0x200)
> > np->full_duplex = 1;
> > - np->default_port = option & 15;
> > - if (np->default_port)
> > - np->medialock = 1;
> > + if (option & 15)
> > + printk(KERN_INFO "%s: ignoring user supplied media type %d",
> > + dev->name, option & 15);
> > }
> > if (find_cnt < MAX_UNITS && full_duplex[find_cnt] > 0)
> > np->full_duplex = 1;
>
> I'm not sure this part is something we want in the mainstream kernel...
>

The winbond driver always ignored the user supplied media type, I only
added a warning.
medialock and default_port were write-only variables ;-)

--
        Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 15 2001 - 21:00:30 EST