Re: Deadlock in 2.2 sock_alloc_send_skb?

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Thu May 10 2001 - 07:57:49 EST

Next message: Holger Lubitz: "Re: ECN: Volunteers needed"
Previous message: Nico Blanke: "Compiler-Error"
In reply to: Ulrich.Weigand@de.ibm.com: "Deadlock in 2.2 sock_alloc_send_skb?"
Next in thread: Andi Kleen: "Re: Deadlock in 2.2 sock_alloc_send_skb?"
Reply: Andi Kleen: "Re: Deadlock in 2.2 sock_alloc_send_skb?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> If that happens, and the socket uses GFP_ATOMIC allocation, the while (1)
> loop in sock_alloc_send_skb() will endlessly spin, without ever calling
> schedule(), and all the time holding the kernel lock ...

If the socket is using GFP_ATOMIC allocation it should never loop. That is
-not-allowed-.

> Do you agree that this is a problem? What do you think about this fix:

Looks good

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Holger Lubitz: "Re: ECN: Volunteers needed"
Previous message: Nico Blanke: "Compiler-Error"
In reply to: Ulrich.Weigand@de.ibm.com: "Deadlock in 2.2 sock_alloc_send_skb?"
Next in thread: Andi Kleen: "Re: Deadlock in 2.2 sock_alloc_send_skb?"
Reply: Andi Kleen: "Re: Deadlock in 2.2 sock_alloc_send_skb?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue May 15 2001 - 21:00:22 EST