RE: PCMCIA IDE flash problem found

From: Khachaturov, Vassilii (Vassilii.Khachaturov@comverse.com)
Date: Tue May 08 2001 - 13:05:04 EST


Why did not you take care of the request_region() call and just disabled it?
The ports will be considered free by the system, and another device might
grab them later on!

Vassilii

-----Original Message-----
From: Pavel Machek [mailto:pavel@suse.cz]
Sent: Tuesday, May 08, 2001 8:14 AM
To: kernel list
Subject: PCMCIA IDE flash problem found

Hi!

2.4.[123] changed name of ide-cs module, which means your pcmcia setup
breaks... This is how to undo the damage. Works for me, do *not* apply
into anything official.

                                                                Pavel

--- clean/drivers/ide/ide-cs.c Sun Apr 1 00:23:29 2001
+++ linux/drivers/ide/ide-cs.c Tue May 8 14:06:09 2001
@@ -95,7 +96,7 @@
 static int ide_event(event_t event, int priority,
                      event_callback_args_t *args);
 
-static dev_info_t dev_info = "ide-cs";
+static dev_info_t dev_info = "ide_cs";
 
 static dev_link_t *ide_attach(void);
 static void ide_detach(dev_link_t *);
@@ -388,9 +389,12 @@
         MOD_DEC_USE_COUNT;
     }
 
+#if 0
     request_region(link->io.BasePort1, link->io.NumPorts1,"ide-cs");
     if (link->io.NumPorts2)
         request_region(link->io.BasePort2, link->io.NumPorts2,"ide-cs");
+#endif
+ printk("Should call request_region\n");
     
     info->ndev = 0;
     link->dev = NULL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 15 2001 - 21:00:13 EST