Re: [PATCH] proc_mknod() should check the mode parameter

From: Alexander Viro (viro@math.psu.edu)
Date: Wed Apr 18 2001 - 16:51:08 EST


On Wed, 18 Apr 2001, Erik Mouw wrote:

> Hi all,
>
> While documenting the procfs interface (more of that later), I came
> across proc_mknod() which is supposed to be used to create devices in
> the procfs. IMHO it should therefore check if the mode parameter
> contains S_IFBLK or S_IFCHR.

Why? All callers of proc_mknod() are in the kernel and they should
know better. I could understand
        if (....)
                BUG();
but silently doing nothing is really odd.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:28 EST