Re: [PATCH] Bug in do_mount()

From: Alexander Viro (viro@math.psu.edu)
Date: Sat Mar 24 2001 - 09:13:46 EST


On Sat, 24 Mar 2001, Jorgen Cederlof wrote:

> if (list_empty(&sb->s_mounts))
> kill_super(sb, 0);
> + else
> + put_filesystem(fstype);
> goto unlock_out;

That's completely wrong. Reference acquired by get_fs_type() is
released by put_filesystem() (near fs_out), _NOT_ by kill_super().
kill_super() releases the reference stored in ->s_type (created
by get_sb_...()). If superblock stays alive you should not release it.

What bug are you trying to fix?
                                                        Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 31 2001 - 21:00:10 EST