[PATCH] de4x5.c: don't reference skb after passing it to netif_rx

From: Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Date: Mon Feb 26 2001 - 18:33:59 EST


        I've just read davem's post at netdev about the brokeness of
referencing skbs after passing it to netif_rx, so please consider applying
this patch. Ah, this was just added to the Janitor's TODO list at
http://bazar.conectiva.com.br/~acme/TODO and I'm doing a quick audit in the
net drivers searching for this, maybe some more patches will follow.

- Arnaldo

--- linux-2.4.2/drivers/net/de4x5.c Fri Feb 9 17:40:02 2001
+++ linux-2.4.2.acme/drivers/net/de4x5.c Mon Feb 26 22:02:50 2001
@@ -1731,13 +1731,13 @@
                     /* Push up the protocol stack */
+ de4x5_local_stats(dev, skb->data, pkt_len);
                     /* Update stats */
                     dev->last_rx = jiffies;
                      lp->stats.rx_bytes += pkt_len;
- de4x5_local_stats(dev, skb->data, pkt_len);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Feb 28 2001 - 21:00:12 EST