refill_freelist() and page_launder()

From: Marcelo Tosatti (
Date: Sat Feb 24 2001 - 14:50:51 EST


refill_freelist() (fs/buffer.c) calls page_launder(GFP_BUFFER) after
syncing some of the oldest dirty buffers.

As fair as I can see, that used to make sense because clean pages could be
freed with page_launder(GFP_BUFFER) -- this could avoid a potential sleep
on kswapd when trying to allocate a buffer page with grow_buffers().

But now __alloc_pages will not wait kswapd anymore.

Instead the running thread will free clean pages only when it has to call
page_launder() itself because kswapd could not keep up.

Could you remove the call to page_launder() and the if() on top on your
tree ?

Come one, doing by hand its easier than a patch.

Here's the function:

 * We used to try various strange things. Let's not.
 * We'll just try to balance dirty buffers, and possibly
 * launder some pages.
static void refill_freelist(int size)
        if (free_shortage())
                page_launder(GFP_BUFFER, 0);

grow_buffers() calls alloc_page(GFP_BUFFER).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Feb 28 2001 - 21:00:08 EST