Re: [PATCH] starfire reads irq before pci_enable_device.

From: Manfred Spraul (manfred@colorfullife.com)
Date: Wed Feb 07 2001 - 15:34:49 EST

Next message: Guest section DW: "Re: IDE PROBLEM 2.4.0 and 2.4.1 ..."
Previous message: Doug Ledford: "Re: 2.4.1-ac4 aic7xxx driver, heads-up re possible problem"
In reply to: Jeff Garzik: "Re: [PATCH] starfire reads irq before pci_enable_device."
Next in thread: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jeff Garzik wrote:
>
> + SET_MODULE_OWNER(dev);
>
> irq = pdev->irq;
>

One question:
The code copies 'pdev->irq' into 'dev->irq'.

Is that required, who need 'dev->irq'?

> retval = request_irq(dev->irq, &intr_handler, SA_SHIRQ, dev->name, dev);

Can't the driver use?
retval = request_irq(np->pci_dev->irq)

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Guest section DW: "Re: IDE PROBLEM 2.4.0 and 2.4.1 ..."
Previous message: Doug Ledford: "Re: 2.4.1-ac4 aic7xxx driver, heads-up re possible problem"
In reply to: Jeff Garzik: "Re: [PATCH] starfire reads irq before pci_enable_device."
Next in thread: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Feb 07 2001 - 21:00:28 EST