modversions.h source pollution in 2.4

From: Keith Owens (kaos@ocs.com.au)
Date: Sun Feb 04 2001 - 19:07:19 EST


The following files explicitly include linux/modversions.h. They
should not do this, the Makefiles are responsible for automatically
including modversions.h. Since modversions.h will disappear in 2.5,
consider this advance warning that the offending sources can expect
problems.

Maintainers: please fix these sources by removing modversions.h.

arch/ia64/kernel/palinfo.c
drivers/char/amiserial.c
drivers/char/dtlk.c
drivers/char/ip2.c
drivers/char/ip2main.c
drivers/char/rocket.c
drivers/char/serial.c
drivers/md/lvm.c
drivers/net/eepro100.c
drivers/net/epic100.c
drivers/net/starfire.c
drivers/net/wan/lmc/lmc_main.c

The presence of symbols like foo__ver_foo is not a reason to explicitly
include modversions.h, see http://www.tux.org/lkml/#s8-8.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 07 2001 - 21:00:20 EST