Re: [PATCH] minor ne2k-pci irq fix

From: Linus Torvalds (
Date: Sat Feb 03 2001 - 15:20:32 EST

On Thu, 1 Feb 2001, Jeff Garzik wrote:
> > Probably I've missed this because the last time I hit such a thing was
> > when my ob800 bios mapped the cardbus memory BAR's into bogus legacy
> > 0xe0000 area. Hence there was good reason to read and correct this before
> > trying to enable the device.
> This is a PCI fixup, the driver shouldn't have to worry about this..

Actually, I'd rather see the _drivers_ do most of the fixups for their own
chips, and leave the global PCI fixups for things like

 - PCI/ISA/whatever bridges that affect drivers for _other_ chips. I hate
   having some random PCI driver having to know about the fact that it
   might be behind a bridge that needs special initialization. That kind
   of "non-local" knowledge is that the PCI fixups are there for.

 - stuff that needs to be fixed up early in order to have a working system
   and make sure that we don't have any resource clashes we can't fix up
   later on.

But if there is a BIOS/chip bug that affects only one driver, and that bug
is local to that driver only and can't affect anything else, then I'd
rather see the driver keep track of it. It's easy enough for a driver to
do any required fixup before it actually calls "pci_enable_device()".


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Feb 07 2001 - 21:00:18 EST