[PATCH] atarilance using freed skb

From: Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Date: Sat Jan 06 2001 - 19:39:30 EST


Em Sat, Jan 06, 2001 at 09:35:08PM -0200, Arnaldo Carvalho de Melo escreveu:
> Alan,
>
> Paul Gortmaker found a similar one for lance, so I'm looking at
> some other drivers to see if this happens, bagetlance has it as well,
> here is the patch.

Another one:

--- linux-2.4.0-ac2/drivers/net/atarilance.c Mon Jan 1 14:42:28 2001
+++ linux-2.4.0-ac2.acme/drivers/net/atarilance.c Sat Jan 6 22:36:23 2001
@@ -820,9 +820,9 @@
         head->misc = 0;
         lp->memcpy_f( PKTBUF_ADDR(head), (void *)skb->data, skb->len );
         head->flag = TMD1_OWN_CHIP | TMD1_ENP | TMD1_STP;
+ lp->stats.tx_bytes += skb->len;
         dev_kfree_skb( skb );
         lp->cur_tx++;
- lp->stats.tx_bytes += skb->len;
         while( lp->cur_tx >= TX_RING_SIZE && lp->dirty_tx >= TX_RING_SIZE ) {
                 lp->cur_tx -= TX_RING_SIZE;
                 lp->dirty_tx -= TX_RING_SIZE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jan 07 2001 - 21:00:26 EST